Skip to content

Update rules_go and gazelle to fix postsubmit job#7493

Closed
rifelpet wants to merge 2 commits intokubernetes:masterfrom
rifelpet:bazel-fix
Closed

Update rules_go and gazelle to fix postsubmit job#7493
rifelpet wants to merge 2 commits intokubernetes:masterfrom
rifelpet:bazel-fix

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Aug 30, 2019 •
edited
Loading

make bazel-crossbuild-kops is currently failing due to a bug in rules_go which was fixed. Also updating gazelle while I'm at it.

rules_go 0.19.0 changed cross-compiling to no longer use cgo by default. I'm not sure if we should add the _cgo platform suffix to continue with the past behavior or if its fine to not use cgo.

I'm hoping this fixes the kops-postsubmit job!

@rifelpet
Update rules_go and gazelle to fix postsubmit job
588d96c 
`make bazel-crossbuild-kops` is currently failing [0] due to a bug in rules_go which was fixed [1]. Also updating gazelle while I'm at it.

[0] https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/kops-postsubmit/1167506341137223682
[1] bazel-contrib/rules_go#2118
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rifelpet
To complete the pull request process, please assign kashifsaadat
You can assign the PR to them by writing /assign @kashifsaadat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Aug 30, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 30, 2019

@rifelpet: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws c279c8c link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Copy Markdown
Member

justinsb commented Aug 31, 2019

Thanks @rifelpet - this is awesome.

I think the problem we're both hitting is the problem you pointed out in #7499 (comment)

Specifically in this case, https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/7493/pull-kops-e2e-kubernetes-aws/1167564372923387907/artifacts/52.212.243.151/kops-configuration.log

ExecStart=/usr/bin/docker run -v /:/rootfs/ -v /var/run/dbus:/var/run/dbus -v /run/systemd:/run/systemd -v /usr/local/bin:/opt/kops/bin:ro --env PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/kops/bin --net=host --pid=host --privileged --env KUBECONFIG=/rootfs/var/lib/kops/kubeconfig  -e 'AWS_REGION=eu-west-1'  protokube:{STABLE_KOPS_VERSION} /usr/bin/protokube --channels=s3://k8s-kops-prow/e2e-2d1bd09636-ff1eb.test-cncf-aws.k8s.io/addons/bootstrap-channel.yaml --cloud=aws --containerized=true --dns-internal-suffix=.internal.e2e-2d1bd09636-ff1eb.test-cncf-aws.k8s.io --dns=aws-route53 --initialize-rbac=true --manage-etcd=false --master=true --remove-dns-names=etcd-a.internal.e2e-2d1bd09636-ff1eb.test-cncf-aws.k8s.io,etcd-events-a.internal.e2e-2d1bd09636-ff1eb.test-cncf-aws.k8s.io --v=4 --zone=*/ZEMLNXIIWQ0RV

Note the "protokube:{STABLE_KOPS_VERSION}" instead of a real tag...

That in turn is because rules_go 0.19.0 now requires --stamp to be passed to use x_defs; I'm trying this: https://github.com/kubernetes/kops/compare/5a44f2095749ea1100d5ab797738ab255ea1ceba..8daf1c56d00e81f41d0ae26b9e0fd28d56e47b29

We'll see if that works :-)

@rifelpet rifelpet closed this Aug 31, 2019
@justinsb
Copy link
Copy Markdown
Member

justinsb commented Aug 31, 2019

Though we're both hitting the same error with rules_go .... I didn't fix the cgo issue you fixed so I think we probably do still need this PR @rifelpet (?)

@rifelpet rifelpet mentioned this pull request Sep 3, 2019
Merged
@rifelpet rifelpet deleted the bazel-fix branch August 6, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corteva-ryanbonham corteva-ryanbonham Awaiting requested review from corteva-ryanbonham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rifelpet @k8s-ci-robot @justinsb